[3.3.0] Forum Subs

[stone23]

Does acp work normally on productions server when extensions are disabled?

Yes the ACP works normally, except for the links of all the deactivated extensions which are displayed only with the language keys, which is normal.

[stone23]

One other question - are you using Cloudflare (or similar) which may be causing/contributing to the problem?

No, none of that...

[devspace]

except for the links of all the deactivated extensions which are displayed only with the language keys, which is normal.

That is not normal at all - do you have a screenshot?

The only place where I would expect to see language keys is in the ACP log.

How about your firewall - is that configured to allow outgoing requests?

[stone23]

That is not normal at all - do you have a screenshot?

No, I didn't take a screenshot...

The only place where I would expect to see language keys is in the ACP log.

Sorry I made a mistake, it's true that the modules are no longer displayed when the extensions are disabled without deleting the data.

How about your firewall - is that configured to allow outgoing requests?

Yes since the extension worked with phpBB 3.3.9...
It's since the update to phpBB 3.3.10 that my problem came back...

[stone23]

How about your firewall - is that configured to allow outgoing requests?

Are you talking about the php firewall?
Because I can't configure it...
I am creating a subdomain to create an online testing forum.

[stone23]

How about your firewall - is that configured to allow outgoing requests?

I changed my php configuration and disabled the php firewall.
The pages are displayed but it is long and the version of the extension cannot be checked

ScreenShot036.jpg

[Manard82]

Hello,

In the management of groups and users, the name "ACP_USER_UTILS" has not been replaced by its the corresponding translation



With my thanks for taking this replacement into account

Bernard

[doublejay]

Using PHP 8.2, Postgresql 15 and phpBB 3.3.11, I get the following warning:

[phpBB Debug] PHP Warning: in file [ROOT]/ext/devspace/forumsubs/controller/main_controller.php on line 92: Undefined property: PgSql/Result::$num_rows

I guess it has something todo with changing the postgresql results from resource to objects in PHP 8.1:

https://php.watch/versions/8.1/PgSQL-resource

The offending line is:

Code: Select all

$num_rows = $result->num_rows;

[devspace]

Using PHP 8.2, Postgresql 15 and phpBB 3.3.11, I get the following warning:

[phpBB Debug] PHP Warning: in file [ROOT]/ext/devspace/forumsubs/controller/main_controller.php on line 92: Undefined property: PgSql/Result::$num_rows

I guess it has something todo with changing the postgresql results from resource to objects in PHP 8.1:

https://php.watch/versions/8.1/PgSQL-resource

The offending line is:

Code: Select all

$num_rows = $result->num_rows;

Can you try

Find // Get the member's subscriptions

Add before $num_rows = 0;

[doublejay]

You mean replacing

Code: Select all

$num_rows = $result->num_rows;

with

Code: Select all

$num_rows = 0;

This will resolve the warning, but I don't know if this is the best solution.

If you really meant adding the line while keeping the offending line as-is, no, the warning is the same (because the offending line did not change).

[doublejay]

So the problem is the extensions code is not DB agnostic.

If you use mySQL everything is fine, because mysqli_query will return a mysqli_result class. This class has a "num_rows" property:
https://www.php.net/manual/en/class.mysqli-result.php

But, if you use PostgreSQL as backend, pg_query is used by phpBBs DB driver, which returns a PgSql\Result class. This class has no "num_rows" property (it has no properties at all):
https://www.php.net/manual/en/class.pgsql-result.php

Thus, trying to access "num_rows" on a Postgres result will issue a Warning.

Edit: For Postgres, you would have to use pg_num_rows($result) instead of $result->num_rows. But of course then it will fail for everything that is not postgres.I don't know what the "phpBB way" of solving this is, but the root cause seems to be clear.

[devspace]

Do you have this problem with PHP 8.1?

Whilst some/most of phpBB will work with PHP 8.2 the upper PHP version is still at 8.1

This may well be a bug in phpBB's dbal with PHP 8.2 and needs to be reported in phpBB's bug tracker.

[doublejay]

No, it's because you are using code that only works with MySQL.

Please read my last post again. Accessing a "num_rows" property only works with MySQL. With PostgreSQL you get a completely different result class, one that has no such property.

Your code is not DB agnostic. It has nothing to do with PHP 8.2 or phpBB dbal.

[nou nou]

Hello,


Trying to use Forum Subscriptions but getting these errors:

Code: Select all

General Error
SQL ERROR [ mysqli ]

Unknown column 'u.username' in 'field list' [1054]

SQL

SELECT u.user_id, u.username, u.username_clean, u.user_colour, fw.forum_id FROM (phpbb_ailabs_users u CROSS JOIN phpbb_forums_watch fw) WHERE u.user_id = fw.user_id AND fw.forum_id = 60 ORDER BY u.username_clean

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 1031
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 202
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 353
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/ext/devspace/forumsubs/core/ext_functions.php
LINE: 203
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/ext/devspace/forumsubs/controller/admin_controller.php
LINE: 83
CALL: devspace\forumsubs\core\ext_functions->get_subscribed_users()

FILE: [ROOT]/ext/devspace/forumsubs/acp/acp_forumsubs_module.php
LINE: 26
CALL: devspace\forumsubs\controller\admin_controller->display_output()

FILE: [ROOT]/includes/functions_module.php
LINE: 676
CALL: devspace\forumsubs\acp\acp_forumsubs_module->main()

FILE: [ROOT]/adm/index.php
LINE: 81
CALL: p_master->load_active()

When I go to ACP_USER_UTILS/Forum Subscriptions in the ACP

I also get this when I want to go to the Subscriptions page in the User Administer ACP:

Code: Select all

General Error
SQL ERROR [ mysqli ]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3 [1064]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.

Previously, I did have this message when trying to enable the extension:

Code: Select all

Something went wrong during the request and an exception was thrown. The changes made before the error occurred were reversed to the best of our abilities, but you should check the board for errors.

A module already exists: ACP_USER_UTILS

Return to the extension list

And when trying a second time:

Code: Select all

General Error
SQL ERROR [ mysqli ]

Duplicate entry 'devspace/forumsubs' for key 'phpbb_ext.ext_name' [1062]

SQL

INSERT INTO phpbb_ext (ext_name, ext_active, ext_state) VALUES ('devspace/forumsubs', 0, 'b:1;')

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 1031
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 202
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 353
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/phpbb/extension/manager.php
LINE: 179
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/phpbb/extension/manager.php
LINE: 241
CALL: phpbb\extension\manager->update_state()

FILE: [ROOT]/includes/acp/acp_extensions.php
LINE: 209
CALL: phpbb\extension\manager->enable_step()

FILE: [ROOT]/includes/functions_module.php
LINE: 676
CALL: acp_extensions->main()

FILE: [ROOT]/adm/index.php
LINE: 81
CALL: p_master->load_active()

After which I renamed that (empty looking) module in the ACP and deleted the entry from the database. The extension then enables but throws the errors I mentioned before.

I may have had a version of this extension before, possibly from when it was a david63 extension. I tested quite a few of his through the years

Hope you can help!

Thanks!


EDIT: One more thing, when I first enable the extension successfully, this shows in the Customise tab of the ACP:

Code: Select all

[phpBB Debug] PHP Warning: in file [ROOT]/vendor/symfony/config/Resource/ReflectionClassResource.php on line 139: Use of undefined constant CHAT_STATUS_AVAILABLE - assumed 'CHAT_STATUS_AVAILABLE' (this will throw an Error in a future version of PHP)
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/symfony/config/Resource/ReflectionClassResource.php on line 139: Use of undefined constant CHAT_STATUS_AWAY - assumed 'CHAT_STATUS_AWAY' (this will throw an Error in a future version of PHP)
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/symfony/config/Resource/ReflectionClassResource.php on line 139: Use of undefined constant CHAT_STATUS_BUSY - assumed 'CHAT_STATUS_BUSY' (this will throw an Error in a future version of PHP)
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/symfony/config/Resource/ReflectionClassResource.php on line 139: Use of undefined constant CHAT_STATUS_HIDDEN - assumed 'CHAT_STATUS_HIDDEN' (this will throw an Error in a future version of PHP)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions_acp.php on line 139: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3035)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions_acp.php on line 139: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3035)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions_acp.php on line 139: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3035)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions_acp.php on line 139: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3035)

Ctrl-F5 solves this...

EDIT2:

phpBB 3.3.11
php7.4

[devspace]

Sorry - I missed this as I've been away.

Not sure why you are getting these errors as I cannot reproduce them. Will look into it later.

[doublejay]

Can you also please check the extension together with PostgreSQL instead of mySQL?

[devspace]

Can you also please check the extension together with PostgreSQL instead of mySQL?

Why - what is the problem?

[nou nou]

Sorry - I missed this as I've been away.

Not sure why you are getting these errors as I cannot reproduce them. Will look into it later.

No problem and no rush, thanks for taking a look!

[sentience]

I'm curious to understand the recommended workflow for adding users to a group after using this extension to subscribe that group to a forum.

Ideally, if I add a new user to a group, I'd like this extension to automatically apply any previously-created group forum subscriptions to that user. But that doesn't seem to be how this extension works. (Please let me know if I've misunderstood.)

The next thing I was hoping was that I could add the new user to the group, then in the Group forum subscriptions UI click Update to "re-apply" the existing group forum subscriptions, and have the newly-added user added to the subscription. But this doesn't seem to work either.

The only workflow that seems to work for me is:

1. Add the new user to the existing group
2. In Group forum subscriptions, de-select the forum(s) and click Update to remove the group forum subscription
3. In Group forum subscriptions, re-select the forum(s) and click Update to re-create the group forum subscription (including the new user)

Is that the intended workflow?